Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lib/reactionview/template/handlers/herb/herb.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,28 @@ def add_expression_block(indicator, code)
add_rails_expression(indicator, code, wrap_parentheses: false)
end

def add_expression_block_end(code)
flush_newline_if_pending(@src)

terminate_expression

trailing_newline = code.end_with?("\n")
code_stripped = code.chomp

@src.chomp! if @src.end_with?("\n") && code_stripped.start_with?(" ")

@src << " " << code_stripped

# Don't add closing parens — add_expression_block doesn't open any
@src << if code.include?("#") || trailing_newline
"\n"
else
";"
end

@buffer_on_stack = false
end

def add_rails_expression(indicator, code, wrap_parentheses:)
flush_newline_if_pending(@src)

Expand Down
20 changes: 10 additions & 10 deletions test/snapshot_utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -104,39 +104,39 @@ def snapshot_changed?(content, source, options = {})
previous_content = snapshot_file(source, options).read

if previous_content == content
puts "\n\nSnapshot for '#{class_name} #{name}' didn't change: \n#{snapshot_file(source, options)}\n"
puts "\n\nSnapshot for '#{self.class.name} #{name}' didn't change: \n#{snapshot_file(source, options)}\n"
false
else
puts "\n\nSnapshot for '#{class_name} #{name}' changed:\n"
puts "\n\nSnapshot for '#{self.class.name} #{name}' changed:\n"

puts Difftastic::Differ.new(color: :always).diff_strings(previous_content, content)
puts "==============="
true
end
else
puts "\n\nSnapshot for '#{class_name} #{name}' doesn't exist at: \n#{snapshot_file(source, options)}\n"
puts "\n\nSnapshot for '#{self.class.name} #{name}' doesn't exist at: \n#{snapshot_file(source, options)}\n"
true
end
end

def save_failures_to_snapshot(content, source, options = {})
return unless snapshot_changed?(content, source, options)

puts "\n==== [ Input for '#{class_name} #{name}' ] ====="
puts "\n==== [ Input for '#{self.class.name} #{name}' ] ====="
puts source
puts "\n\n"

if !ENV["FORCE_UPDATE_SNAPSHOTS"].nil? ||
ask?("Do you want to update (or create) the snapshot for '#{class_name} #{name}'?")
ask?("Do you want to update (or create) the snapshot for '#{self.class.name} #{name}'?")

puts "\nUpdating Snapshot for '#{class_name} #{name}' at: \n#{snapshot_file(source, options)}\n"
puts "\nUpdating Snapshot for '#{self.class.name} #{name}' at: \n#{snapshot_file(source, options)}\n"

FileUtils.mkdir_p(snapshot_file(source, options).dirname)
snapshot_file(source, options).write(content)

puts "\nSnapshot for '#{class_name} #{name}' written: \n#{snapshot_file(source, options)}\n"
puts "\nSnapshot for '#{self.class.name} #{name}' written: \n#{snapshot_file(source, options)}\n"
else
puts "\nNot updating snapshot for '#{class_name} #{name}' at: \n#{snapshot_file(source, options)}.\n"
puts "\nNot updating snapshot for '#{self.class.name} #{name}' at: \n#{snapshot_file(source, options)}.\n"
end
end

Expand Down Expand Up @@ -164,9 +164,9 @@ def assert_snapshot_matches(actual, source, options = {}, mode: nil)
#{Difftastic::Differ.new(color: :always).diff_strings(snapshot_file(source, snapshot_opts).read, actual)}
\e[31m#{divider}

Snapshots for "#{class_name} #{name}" didn't match.
Snapshots for "#{self.class.name} #{name}" didn't match.

Run the test using UPDATE_SNAPSHOTS=true to update (or create) the snapshot file for "#{class_name} #{name}"
Run the test using UPDATE_SNAPSHOTS=true to update (or create) the snapshot file for "#{self.class.name} #{name}"

UPDATE_SNAPSHOTS=true minitest #{e.location}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
if true
@output_buffer.safe_append=' '.freeze; @output_buffer.append= content_tag(:div, class: "wrapper") do; @output_buffer.safe_append='
<p>Hello</p>
'.freeze; end
else
@output_buffer.safe_append=' '.freeze; @output_buffer.append= content_tag(:div, class: "fallback") do; @output_buffer.safe_append='
<p>Fallback</p>
'.freeze; end
end
@output_buffer
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<div class="wrapper">
<p>Hello</p>
</div>
17 changes: 17 additions & 0 deletions test/template/handlers/herb_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -342,4 +342,21 @@ def @view_context.ui_badge(count, **_options)
assert_compiled_snapshot(template)
assert_evaluated_snapshot(template, ivars: { config: { key: "value" } })
end

test "render with block (e.g. component with do/end)" do
template = <<~HTML
<% if true %>
<%= content_tag(:div, class: "wrapper") do %>
<p>Hello</p>
<% end %>
<% else %>
<%= content_tag(:div, class: "fallback") do %>
<p>Fallback</p>
<% end %>
<% end %>
HTML

assert_compiled_snapshot(template)
assert_evaluated_snapshot(template)
end
end