Implement Trie Data Structure #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
…ons. Add test cases to verify functionality.
marcosfede
reviewed
Aug 26, 2024
Comment on lines
+8
to
+17
| def test_insert_and_search(self): | ||
| words = ["apple", "app", "apricot", "banana"] | ||
| for word in words: | ||
| self.trie.insert(word) | ||
|
|
||
| for word in words: | ||
| self.assertTrue(self.trie.search(word)) | ||
|
|
||
| self.assertFalse(self.trie.search("grape")) | ||
| self.assertFalse(self.trie.search("ap")) |
marcosfede
reviewed
Aug 26, 2024
Comment on lines
+19
to
+31
| def test_delete(self): | ||
| words = ["apple", "app", "apricot", "banana"] | ||
| for word in words: | ||
| self.trie.insert(word) | ||
|
|
||
| self.assertTrue(self.trie.delete("apple")) | ||
| self.assertFalse(self.trie.search("apple")) | ||
| self.assertTrue(self.trie.search("app")) | ||
|
|
||
| self.assertTrue(self.trie.delete("banana")) | ||
| self.assertFalse(self.trie.search("banana")) | ||
|
|
||
| self.assertFalse(self.trie.delete("grape")) |
marcosfede
reviewed
Aug 26, 2024
Comment on lines
+33
to
+37
| def test_empty_string(self): | ||
| self.trie.insert("") | ||
| self.assertTrue(self.trie.search("")) | ||
| self.assertTrue(self.trie.delete("")) | ||
| self.assertFalse(self.trie.search("")) |
|
hey devin, can you clean up this PR? |
marcosfede
reviewed
Aug 26, 2024
|
test |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trie Data Structure Implementation
This pull request (#88) implements a Trie data structure in Python for the
marcosfede/algorithmsrepository. The Trie is a tree-like data structure used for efficient storage and retrieval of strings, particularly useful for tasks such as autocomplete and spell-checking.Features
Implemented in
trie/trie.py:TrieNodeclass for representing nodes in the TrieTrieclass with the following methods:insert(word): Insert a word into the Triesearch(word, is_prefix=False): Search for a word or prefix in the Triedelete(word): Delete a word from the TrieTime complexity:
Space complexity: O(n * m), where n is the number of words and m is the average length of words
Implementation Details
deleteoperation uses an iterative approach to handle long words efficientlysearchmethod includes anis_prefixparameter to support prefix searchingTesting
Comprehensive unit tests implemented in
trie/test_trie.pycover:New test cases added for more comprehensive coverage:
test_unicode_characters: Ensures correct handling of non-ASCII characterstest_large_dataset: Verifies performance with a large number of wordstest_prefix_matching: Checks prefix search functionalitytest_edge_cases: Tests boundary conditions and edge scenariosThese additional tests ensure the robustness and reliability of the Trie implementation across various use cases.
Improvements
Next Steps
This implementation provides a solid foundation for Trie-based algorithms and can be easily extended for various applications.
PR: #88
URL: #88
Requested by: Federico
Link to Devin run: https://staging.itsdev.in/devin/21a67400cd63476a80b6a041168e9615