MBS-10618: Fix mathjax display#66
Merged
marcusgreen merged 2 commits intomarcusgreen:mainfrom Feb 23, 2026
Merged
Conversation
575630c to
710efa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic issue here is that the external LLM will send back LaTeX code wrapped in
\( ... \)delimiters, sometimes additionally escaped like it has to be to be JSON-parsable, sometimes not. It will then be escaped by theprocess_feedbackfunction and JSON-parsed which will then end up with a properly parsed text string which ideally still contains\( ... \). However after that (and that's why the tests so far have been green, but MathJax still has not been applied), we send the results throughformat_textwhich will not recognize this, but instead we have to add an additional backslash to each backslash forformat_textto properly let it through as backslash instead of a escaping symbol.