MBS-10618: harden process feedback#67
Merged
marcusgreen merged 1 commit intomarcusgreen:mainfrom Feb 25, 2026
Merged
Conversation
Owner
|
Thanks Andreas, @PhMemmel has been working hard on this and I was looking at and testing the code only this morning. It occurs to me it would be good if there were a trivial way to confirm that the returned json is actually well formed. |
Contributor
|
Just FYI: @TobiGa Did some internal testing and review and considered it as a good patch :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Marcus,
we found, that when the LLM reponse is valid json, the parsing fails in some cases, when the json contains already 4 backslashes before "(" in an Mathjax expression.
Here is my fix. @PhMemmel maybe you are able to review this too?
Cheers, Andi