Evaluate Files SDK for AgentPond object storage - #51
Conversation
🦋 Changeset detectedLatest commit: 9cacea6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cacea6e8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const environment = initAgentPondEnvironment(name, { | ||
| cwd: context.rootDir, | ||
| storeType: store, | ||
| filesSdk, | ||
| }); |
There was a problem hiding this comment.
When an environment file already exists, initAgentPondEnvironment() deliberately leaves it unchanged, but this action validates the persisted file and then prints the newly supplied filesSdk values. Re-running env init production --provider gcs --bucket new-bucket for an existing S3 environment therefore exits successfully and reports GCS/new-bucket even though subsequent commands still use the old S3 configuration. Either reject an already initialized name, overwrite it explicitly, or report the settings read back from the persisted file.
Useful? React with 👍 / 👎.
|
|
||
| ```sh | ||
| npm install @agentpond/otel @agentpond/aws @langfuse/otel @langfuse/tracing @opentelemetry/sdk-node | ||
| npm install @agentpond/files-sdk @agentpond/otel files-sdk @opentelemetry/sdk-node |
There was a problem hiding this comment.
The command says it installs the selected provider's peer SDKs, but it installs none of them. For example, the GCS snippet below imports files-sdk/gcs, whose Files SDK peer dependency is @google-cloud/storage; following this installation command and example in a fresh application therefore fails when the adapter loads. Add the provider dependency to the example or provide concrete install commands per demonstrated adapter.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing