Add time controls #285
Merged
Add time controls #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens when client clock is not in sync with the server clock.
Feels more natural after the clock fixes.
Closed
marein
force-pushed
the
9-add-time-controls
branch
from
060c574 to
5b80fc8
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
5b80fc8 to
77e26fd
Compare
This is part of the TimePerGame class now.
marein
force-pushed
the
9-add-time-controls
branch
from
c5821bd to
beb1012
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
747f385 to
cfe4692
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
bcb8e2c to
184cc53
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
b6f3d3d to
6fe393d
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
6fe393d to
9eb1541
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
3dab383 to
bd30829
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
758b85b to
074edd2
Compare
marein
force-pushed
the
9-add-time-controls
branch
2 times, most recently
from
a35424d to
856ec56
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
856ec56 to
a3ccfce
Compare
marein
force-pushed
the
9-add-time-controls
branch
4 times, most recently
from
9846a32 to
e83987f
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
a8a507c to
06a2bb3
Compare
marein
force-pushed
the
9-add-time-controls
branch
from
fd7d81b to
9978b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add time controls, supporting two timer modes: a per-move timer (which resets every turn) and a standard game timer (sudden death) with a configurable increment added after each move. All time is measured in milliseconds. Until the end of the second move, games are aborted rather than timed out. A long-running server process continuously checks all active timers and automatically handles them. To address clock drift, the client synchronizes its clock with the server.
Additionally, redesign the profile and game pages to fit the new content.
Load test has been done with no drop in performance and scalability.