chore : replace MMKV with native device storage#20
Conversation
|
iOS Android |
mrousavy
left a comment
mrousavy
left a comment
There was a problem hiding this comment.
great stuff! did you do a search for mmkv to make sure it's removed everywhere?
example/src/App.tsx
Outdated
| >([]); | ||
| const [prefetchInfo, setPrefetchInfo] = React.useState<string>(''); | ||
| const PREFETCH_URL = 'https://httpbin.org/uuid'; | ||
| const PREFETCH_URL = 'https://pokeapi.co/api/v2/pokemon/ditto'; |
There was a problem hiding this comment.
https://httpbin.org/uuid api is bit slow and takes around 2-3 seconds to respond. The pokeapi is much faster
There was a problem hiding this comment.
I think @Szymon20000 intentionally chose a slower API to test this
There was a problem hiding this comment.
Okk . I will replace it back
But we should make this 5s check configurable. In my testing I found that sometimes api was taking long and was getting a false positive.
// If a fresh prefetched result exists (<=5s old), return it immediately
FetchCache.getResultIfFresh(key, 5_000L)?.let { cached ->
I think we are good here |
|
Why there are Errors everywhere on Nitro (ms) column 😅? |
|
Thank you @riteshshukla04 for the contribution! |
3 participants
Replaces MMKV with User Defaults and Shared preferences