fix(engine, load_from_s3): MCOL-6146 Add mode 2 and 3 to load_from_s3.#3979
Open
mariadb-AlanMologorsky wants to merge 2 commits into
Open
fix(engine, load_from_s3): MCOL-6146 Add mode 2 and 3 to load_from_s3.#3979mariadb-AlanMologorsky wants to merge 2 commits into
mariadb-AlanMologorsky wants to merge 2 commits into
Conversation
Contributor
mariadb-AlanMologorsky
commented
Apr 17, 2026
mariadb-AlanMologorsky
commented
- fix cmapi s3 data load.
- fix engine load_from_s3 implementation.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an optional mode parameter to the S3 data loading workflow, updating the Python API, the C++ UDF, and the SQL stored procedure. Feedback includes a recommendation to explicitly set the argument type in the C++ UDF to prevent undefined behavior, a suggestion to add error handling for integer conversion in the Python controller, and a request to provide a default value for the new parameter in the SQL stored procedure to maintain backward compatibility.
mariadb-LeonidFedorov
approved these changes
Apr 20, 2026
Collaborator
mariadb-LeonidFedorov
left a comment
mariadb-LeonidFedorov
left a comment
There was a problem hiding this comment.
untested, ack
Fix cmapi s3 data load. Fix engine load_from_s3 implementation.
mariadb-AlanMologorsky
force-pushed
the
fix/MCOL-6146-load-from-s3-mode-2-3
branch
from
8cbbddd to
4528518
Compare
mariadb-AlanMologorsky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.