Skip to content

DO NOT MERGE fix(ci): add shmem size for cmapi test container#3983

Draft
mariadb-LeonidFedorov wants to merge 3 commits into
stable-23.10from
cmapi-shmem
Draft

DO NOT MERGE fix(ci): add shmem size for cmapi test container#3983
mariadb-LeonidFedorov wants to merge 3 commits into
stable-23.10from
cmapi-shmem

Conversation

@mariadb-LeonidFedorov

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the shared memory size for cmapi test containers to 500MB to prevent exhaustion during ASAN builds and adds documentation explaining the change. A review comment suggests extending this configuration to upgrade and regression containers to ensure consistency and reliability across all ColumnStore-related test stages.

Comment on lines +79 to +84
# --shm-size: ColumnStore BRM (ExtentMap, VSS, VBBM, CopyLocks) uses
# /dev/shm for SysV/POSIX shared memory. Docker default is 64MiB which
# is easily exhausted under ASAN (2-3x memory footprint), especially
# when cmapi step runs in parallel with upgrade/mtr/regression steps
# on the same pipeline host.
docker_run_args+=(--shm-size=500m --env PYTHONPATH="${PYTHONPATH}")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on lines 79-83 explicitly mentions that cmapi runs in parallel with upgrade and regression steps, and that the shared memory exhaustion is a known issue for ColumnStore components (BRM) under ASAN. While mtr and cmapi now have --shm-size=500m configured, the upgrade (line 85) and regression (line 87) container blocks appear to still use the default 64MiB limit. If these test stages also utilize ColumnStore, they are likely to suffer from the same intermittent failures. Consider applying the increased shared memory size to those container types as well for consistency and CI reliability.

@mariadb-LeonidFedorov mariadb-LeonidFedorov marked this pull request as draft April 20, 2026 16:42
@mariadb-LeonidFedorov mariadb-LeonidFedorov changed the title fix(ci): add shmem size for cmapi test container DO NOT MERGE fix(ci): add shmem size for cmapi test container Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant