MCOL-4627 fix SET int_col=decimal_col returns an error#3999
Open
AestheticAkhmad wants to merge 4 commits into
Open
MCOL-4627 fix SET int_col=decimal_col returns an error#3999AestheticAkhmad wants to merge 4 commits into
AestheticAkhmad wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new test case and corresponding result file to verify the behavior of assigning DECIMAL values to INT columns within the ColumnStore engine. The review feedback points out an inconsistency in rounding behavior for negative values, specifically noting that -0.5 rounds to 0 instead of the expected -1, and suggests expanding the test suite to include NULL values and additional negative rounding scenarios.
drrtuy
requested review from
mariadb-AleksandrAnanchenko,
mariadb-AlexeyAntipovsky and
mariadb-SergeyZefirov
mariadb-SergeyZefirov
approved these changes
May 14, 2026
mariadb-SergeyZefirov
left a comment
mariadb-SergeyZefirov
left a comment
Contributor
There was a problem hiding this comment.
I agree with changes.
mariadb-AlexeyAntipovsky
approved these changes
May 14, 2026
AestheticAkhmad
force-pushed
the
MCOL-4627
branch
from
09b193c to
48b6825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue MCOL-4627 was resolved by solving MCOL-4628. Thus, only testcases were added.
Edit: Gemini found an inconsistency bug, where Columnstore was rounding differently from InnoDB. Now it is fixed, and the testcases are adjusted.