Skip to content
This repository was archived by the owner on Jan 19, 2023. It is now read-only.

Fixes #14 and #26 and #38#35

Open
MrCsabaToth wants to merge 3 commits intomarianocordoba:masterfrom
CsabaConsulting:patch-1
Open

Fixes #14 and #26 and #38#35
MrCsabaToth wants to merge 3 commits intomarianocordoba:masterfrom
CsabaConsulting:patch-1

Conversation

@MrCsabaToth
Copy link
Copy Markdown
Contributor

@MrCsabaToth MrCsabaToth commented May 28, 2021

Regarding #14: swapping the OverflowBox and the Translation + scale transformation seems to help.
Regarding #26: we just need to multiply the margin values by -1 or 1 based on where the menu is. Those factors are already available in the _directionX and _directionY variables.
Regarding #38: using WidgetsBindingObserver's didChangeMetrics callback we call _calculateProps() and also close() if the menu is open.

@MrCsabaToth
Copy link
Copy Markdown
Contributor Author

I tested this in my little environment but please test it as well.

MrCsabaToth added a commit to TrackMyIndoorWorkout/TrackMyIndoorWorkout that referenced this pull request May 28, 2021
@MrCsabaToth
Copy link
Copy Markdown
Contributor Author

For the love of God please merge this so I won't have to rely on my own fork.

@robertmrobo
Copy link
Copy Markdown

Seems like the author of this package has abandoned it. 😔

@robertmrobo
Copy link
Copy Markdown

Do you know of any alternatives I can use for now..? I need a FAB like this one.

@MrCsabaToth
Copy link
Copy Markdown
Contributor Author

Do you know of any alternatives I can use for now..? I need a FAB like this one.

I haven't looked for alternatives, I simply consumed the code into my project. You can see my fix in my patch fork.

@YDA93
Copy link
Copy Markdown

YDA93 commented Apr 6, 2022

Do you know of any alternatives I can use for now..? I need a FAB like this one.

I haven't looked for alternatives, I simply consumed the code into my project. You can see my fix in my patch fork.

@MrCsabaToth If you take over this package and release to pub.dev I would definitely use & help you to maintain it.

What do you think?

@robertmrobo
Copy link
Copy Markdown

Do you know of any alternatives I can use for now..? I need a FAB like this one.

I haven't looked for alternatives, I simply consumed the code into my project. You can see my fix in my patch fork.

@MrCsabaToth If you take over this package and release to pub.dev I would definitely use & help you to maintain it.

What do you think?

I will be happy to help maintain and keep improving it as well... ❤️

@MrCsabaToth
Copy link
Copy Markdown
Contributor Author

I'm thinking about it. I'm looking at the pub.dev entry https://pub.dev/packages/fab_circular_menu and the link to this repository is removed. Publisher unverified.

Using WidgetsBindingObserver's didChangeMetrics call _calculateProps and close.
I haven't tried what this does if the app is resized in a split screen mode, but this is certainly needed for rotation.
@MrCsabaToth MrCsabaToth changed the title Fixing #14 and #26 Fixing #14 and #26 and #38 Jul 14, 2022
@MrCsabaToth MrCsabaToth changed the title Fixing #14 and #26 and #38 Fixes #14 and #26 and #38 Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants