fix: notebook cell_ids for MarimoConvert.to_notebook_v1()#8309
Open
jpopesculian wants to merge 1 commit intomarimo-team:mainfrom
Open
fix: notebook cell_ids for MarimoConvert.to_notebook_v1()#8309jpopesculian wants to merge 1 commit intomarimo-team:mainfrom
jpopesculian wants to merge 1 commit intomarimo-team:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Thanks for revisiting. Would you mind merging this with #8272 ? I think they both require each other. however, I'm a little skeptical on ordering. I think your initial fix was fine if it was only confined to app mode. The issue was improper session blowing away the notebook content in edit mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #8272
The problem was that notebooks created with
NotebookConvert.to_notebook_v1were not adding cell ids so the mismatch caused the notebooks to clear the cells. Solution is to use theCellIdGenerator. I've added some tests to make sure the ids generated match the kernel