stop hardcoding us-central1 as vertex ai default location#8313
stop hardcoding us-central1 as vertex ai default location#8313Mr-Neutr0n wants to merge 2 commits intomarimo-team:mainfrom
Conversation
remove the hardcoded fallback to us-central1 for GOOGLE_CLOUD_LOCATION and let pydantic-ai handle its own default. log a warning when the env var isn't set so users in restricted regions know what's going on instead of getting a cryptic permission error. fixes marimo-team#7899
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
dmadisetti
left a comment
dmadisetti
left a comment
There was a problem hiding this comment.
Minor comment! Might also be better as an info over a warning
| project = os.getenv("GOOGLE_CLOUD_PROJECT") | ||
| location = os.getenv("GOOGLE_CLOUD_LOCATION", "us-central1") | ||
| location = os.getenv("GOOGLE_CLOUD_LOCATION") or None | ||
| if location is None: |
There was a problem hiding this comment.
Good callout, but this doesn't actually re-set location
There was a problem hiding this comment.
Nvm, saw the thread, but would be worth mentioning in a comment that upstream will default to us-central
There was a problem hiding this comment.
Good call, switched it to info and added a comment noting the upstream default. Thanks for the review!
|
@Mr-Neutr0n , thanks! Could you sign the CLA so we can merge this?
|
|
I have read the CLA Document and I hereby sign the CLA |
3 participants
When using Vertex AI without setting
GOOGLE_CLOUD_LOCATION, marimo hardcodesus-central1as the fallback. This silently routes requests to a region that may be blocked by organization policies (like region restriction constraints), giving users a cryptic error with no indication of what went wrong.This removes the hardcoded default and lets pydantic-ai handle the fallback itself. Also adds a warning log when the env var isn't set, so users in restricted environments actually know they need to configure it.
Fixes #7899