fix: --base-url breaks og:thumbnail generation path (marimo-team#8304)#8329
Open
mstanowski wants to merge 1 commit intomarimo-team:mainfrom
Open
fix: --base-url breaks og:thumbnail generation path (marimo-team#8304)#8329mstanowski wants to merge 1 commit intomarimo-team:mainfrom
mstanowski wants to merge 1 commit intomarimo-team:mainfrom
Conversation
On a gallery page, the default card thumbnail was using an absolute /og/thumbnail path, which breaks thumbnail generation when the --base-url option is used in run mode.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
All contributors have signed the CLA ✍️ ✅ |
mscolnick
approved these changes
Feb 16, 2026
peter-gy
approved these changes
Feb 17, 2026
| ? opengraphImage | ||
| : asURL( | ||
| `/og/thumbnail?file=${encodeURIComponent(relativePath)}`, | ||
| `og/thumbnail?file=${encodeURIComponent(relativePath)}`, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
On a gallery page, the default card thumbnail was using an absolute /og/thumbnail path, which breaks thumbnail generation when the --base-url option is used in run mode.
Closes #8304
🔍 Test Plan