feat: include playwright when running sandboxed thumbnail generation#8339
Open
peter-gy wants to merge 1 commit intomarimo-team:mainfrom
Open
feat: include playwright when running sandboxed thumbnail generation#8339peter-gy wants to merge 1 commit intomarimo-team:mainfrom
playwright when running sandboxed thumbnail generation#8339peter-gy wants to merge 1 commit intomarimo-team:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
peter-gy
force-pushed
the
ptr/export-thumbnail-enhancements
branch
from
c78c3dd to
792a878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Ensures that when
—-sandboxis passed we installplaywrighttoo along with the other deps instead of raising error.🔍 Description of Changes
run_in_sandboxre-invokes marimo throughuv run, and the forwarded command no longer includes--sandbox. To preserve intent across re-entry, we now pass sandbox context to the child process so it can recover whether the original invocation wassingleormulti.This keeps thumbnail export consistent with the broader CLI sandbox model introduced in #8076, where behavior is mode-aware:
single: one uv-wrapped processmulti: per-notebook sandbox handling