Update license header template to remove year#3122
Conversation
|
Claude finished @dlwh's task in 4m 59s —— View job Review: PR #3122
Despite the title, this PR bundles license header year bumps (2025 -> 2026) with a major restructuring of the Grug subsystem: migrating the trainer from Specification checkNo linked spec or issue. The PR exceeds ~500 lines of code changes. Per FindingsLost test coverage for
These primitives remain in the codebase as shared library code and are actively imported by the new template. License header year inconsistency -- The templates are bumped to 2026, but every new source file added in this PR ( |
730bfc3 to
8b4ecd3
Compare
|
@claude please look again and lmk if you can think of a better workaround. ideally we wouldn't migrate everything all at once |
|
Claude finished @dlwh's task in 2m 55s —— View job Re-reviewing license header migration approach
🤖 I re-read the PR in its current state (just the 4 license/pre-commit files — my earlier review was stale). The approach looks solid to me. Here's my analysis: How the current approach worksThe key insight is
This is exactly "migrate as files are touched" — staged/modified files get their headers updated on commit, while full-repo scans don't fail or mass-rewrite. Could we do better?I considered a few alternatives:
VerdictI don't think there's a meaningfully better workaround. The current design is clean:
One minor note: if a file has a blank line between its shebang and header (e.g. LGTM as-is. 👍 |
|
Let's just remove the date entirely? Year of creation is trivially available via the repo history already... |
…2026 # Conflicts: # lib/iris/tests/cluster/test_pickle_version_mismatch.py # lib/levanter/scripts/bench/bench_fused_cross_entropy_loss_pallas.py # lib/levanter/scripts/tune/tune_fused_cross_entropy_loss_block_sizes.py # lib/levanter/src/levanter/kernels/pallas/fused_cross_entropy_loss/api.py # lib/levanter/src/levanter/kernels/pallas/fused_cross_entropy_loss/pallas_tpu.py # lib/levanter/src/levanter/kernels/pallas/fused_cross_entropy_loss/tuned_block_sizes.py # lib/levanter/tests/kernels/test_pallas_fused_cross_entropy_loss.py # tests/test_grug_base_template.py
## Summary - remove the year from Marin, Levanter, and Haliax license header templates - migrate existing Python file headers repo-wide from yearful to yearless format - simplify `infra/pre-commit.py` license checks to enforce only the yearless header format - merge latest `origin/main` into this branch ## Validation - run `./infra/pre-commit.py --all-files` (passes) ## Notes - this is a mechanical, comment-only migration across 1411 files
Summary
infra/pre-commit.pylicense checks to enforce only the yearless header formatorigin/maininto this branchValidation
./infra/pre-commit.py --all-files(passes)Notes