fix(iris): poll pending_reason in scheduling diagnostic e2e test#3653
Merged
ravwojdyla merged 1 commit intomainfrom Mar 14, 2026
Merged
fix(iris): poll pending_reason in scheduling diagnostic e2e test#3653ravwojdyla merged 1 commit intomainfrom
ravwojdyla merged 1 commit intomainfrom
Conversation
The test was flaky because it checked `pending_reason` immediately after job submission, before the scheduler loop had evaluated the job. On slow CI runners the reason was still "Pending scheduler feedback" (no "cpu" substring). Poll with a deadline instead. Fixes #3652
rjpower
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_dashboard_scheduling_diagnosticby pollingpending_reasonuntil the scheduler produces a CPU-specific message, instead of a single-shot check that races the scheduler loop.Fixes #3652
Test plan
./infra/pre-commit.py --all-files --fixpasses🤖 Generated with Claude Code