Skip to content

fix(iris): remove misleading 'All' log option and increase default max lines#3683

Merged
rjpower merged 1 commit intomainfrom
claude/issue-3672-20260314-2211
Mar 14, 2026
Merged

fix(iris): remove misleading 'All' log option and increase default max lines#3683
rjpower merged 1 commit intomainfrom
claude/issue-3672-20260314-2211

Conversation

@rjpower
Copy link
Copy Markdown
Collaborator

@rjpower rjpower commented Mar 14, 2026

Drop the 'All' option from the LogViewer dropdown since it was capped at DEFAULT_MAX_TOTAL_LINES anyway. Increase DEFAULT_MAX_TOTAL_LINES from 10k to 100k so CLI users can fetch more logs when needed.

Fixes #3672

…x lines

Drop the 'All' option from the LogViewer dropdown since it was capped at
DEFAULT_MAX_TOTAL_LINES anyway. Increase DEFAULT_MAX_TOTAL_LINES from 10k
to 100k so CLI users can fetch more logs when needed.

Fixes #3672

Co-authored-by: Russell Power <rjpower@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rjpower rjpower requested a review from ravwojdyla March 14, 2026 22:18
@rjpower rjpower enabled auto-merge (squash) March 14, 2026 22:18
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 14, 2026

Claude finished @rjpower's task in 52s —— View job


PR Review

  • Gather context and review changes
  • Post review

Removes the misleading "All" option from the LogViewer dropdown (which was silently capped at DEFAULT_MAX_TOTAL_LINES server-side) and bumps that default from 10k to 100k lines. The change matches its stated objective and fixes #3672.

No issues found. The diff is minimal and correct:

  • service.py:1162 — when max_total_lines is 0 (which "All" sent), the server falls back to DEFAULT_MAX_TOTAL_LINES, so the option was always misleading. Removing it is the right call.
  • The 10x increase to 100k gives CLI users more headroom without removing the cap entirely.

LGTM.

@rjpower rjpower merged commit ce68e8e into main Mar 14, 2026
20 checks passed
@rjpower rjpower deleted the claude/issue-3672-20260314-2211 branch March 14, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iris: LogViewer 'All' option is misleading — still capped at 10k lines

2 participants