[iris] Increase GCP smoke test shell poll timeout#4091
Merged
Conversation
The shell loop that waits for the controller URL file shared its 720s budget with image build/push. When Docker push was slow (~10min in CI), workers had <90s to register before the shell timeout killed the process. Increase from seq 1 360 (720s) to seq 1 900 (1800s) so the Python-side worker-timeout (600s) is the effective deadline.
Contributor
|
Claude finished @rjpower's task in 1m 1s —— View job
ReviewIncreases the shell poll loop from No issues found. The Python-side |
Helw150
pushed a commit
that referenced
this pull request
Apr 8, 2026
The shell loop waiting for the controller URL file had a 720s budget (seq 1 360 * 2s) shared between image build/push and worker startup. When Docker push was slow in CI (~10min), workers had <90s to register before the shell killed the process. Observed in run 23498489452 where the tunnel came up at 15:56:54 but the shell timed out at 15:58:22. Increase to seq 1 900 (1800s) so the Python-side --worker-timeout 600 becomes the effective deadline for worker readiness. Reproduced locally: cluster came up in 376s with the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell loop waiting for the controller URL file had a 720s budget
(seq 1 360 * 2s) shared between image build/push and worker startup.
When Docker push was slow in CI (~10min), workers had <90s to register
before the shell killed the process. Observed in run 23498489452 where
the tunnel came up at 15:56:54 but the shell timed out at 15:58:22.
Increase to seq 1 900 (1800s) so the Python-side --worker-timeout 600
becomes the effective deadline for worker readiness.
Reproduced locally: cluster came up in 376s with the fix.