[Iris] Fix stale detail state and nested child jobs in dashboard#4108
[Iris] Fix stale detail state and nested child jobs in dashboard#4108
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74bd8a8c52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </td> | ||
| <td class="px-3 py-2 text-[13px] text-text-secondary font-mono"> | ||
| {{ childJobDuration(child) }} | ||
| {{ jobDuration(node.job) }} |
There was a problem hiding this comment.
Preserve queued duration for child jobs
The child-jobs table now renders duration via jobDuration(node.job), which returns '-' until startedAt is set. This drops the previous queued-time fallback (queued <relative time> from submittedAt) for pending child jobs, so users lose visibility into how long queued children have been waiting. That is a behavioral regression in the detail page’s status signal for unscheduled child jobs.
Useful? React with 👍 / 👎.
|
@claude Looks like something in the change is breaking the cloud smoke tests expected playwright rules. pls fix. Also please remove the debugging log doc from this branch |
|
Claude finished @rjpower's task in 5m 0s —— View job Fixing Playwright smoke tests and removing debug doc
SummaryRoot cause: In cloud mode, Changes:
Testing: Pre-commit passes. The actual cloud smoke test will validate on the next CI run. |
Remove docs/debug-log-dashboard-route-reuse.md (debugging artifact). Increase sleep duration in test_dashboard_jobs_tab from 30s to 300s so the job stays in RUNNING state long enough for the cloud smoke test to observe it. In cloud mode, scheduling latency for the preceding quick/failed jobs can consume enough time for a 30s sleep to complete before wait_for_state is called. Co-authored-by: Russell Power <rjpower@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix route-reuse stale state in task, worker, log, and job detail views, and show nested child jobs from job detail without leaving the page. Share the job tree logic with JobsTab and keep direct children as the default detail-page view with an all-descendants toggle. Fixes #4107
Fix route-reuse stale state in task, worker, log, and job detail views, and show nested child jobs from job detail without leaving the page. Share the job tree logic with JobsTab and keep direct children as the default detail-page view with an all-descendants toggle.
Fixes #4107