Parallelize data_size computation in consolidate_shard_caches#4116
Merged
Parallelize data_size computation in consolidate_shard_caches#4116
Conversation
yonromai
force-pushed
the
fix/consolidate-metadata-transaction
branch
from
b13c63b to
3da360e
Compare
yonromai
force-pushed
the
romain/parallel-data-size-consolidation
branch
from
c56cd14 to
7b5633c
Compare
yonromai
force-pushed
the
romain/parallel-data-size-consolidation
branch
from
ae461d5 to
118c38a
Compare
TreeStore.open + data_size reads are independent across shards and dominated by remote-storage latency. Use a ThreadPoolExecutor to issue them in parallel, then accumulate offsets serially. Refs #4100 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yonromai
force-pushed
the
romain/parallel-data-size-consolidation
branch
from
118c38a to
b075d72
Compare
rjpower
approved these changes
Mar 25, 2026
Helw150
pushed a commit
that referenced
this pull request
Apr 8, 2026
## Summary - Parallelizes `TreeStore.open` + `data_size` reads across shards using `ThreadPoolExecutor(max_workers=32)` in `consolidate_shard_caches` - These reads are independent and dominated by remote-storage round-trip latency; parallelizing them removes the main bottleneck in the pre-copy phase - Cumulative offset computation remains serial (order-dependent) Stacked on #4105. Refs #4100. Co-authored-by: yoblin <268258002+yoblin@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TreeStore.open+data_sizereads across shards usingThreadPoolExecutor(max_workers=32)inconsolidate_shard_cachesStacked on #4105. Refs #4100.