fix(iris): fixup Starlette on_shutdown#4155
Merged
ravwojdyla merged 2 commits intomainfrom Mar 25, 2026
Merged
Conversation
Contributor
ravwojdyla
commented
Mar 25, 2026
ravwojdyla
commented
- regression from https://github.com/marin-community/marin/pull/4126/changes
…t manager Starlette 0.50 removed the on_shutdown parameter from Starlette.__init__(). Migrate all three call sites to the lifespan async context manager pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tern Consolidates the repeated asynccontextmanager boilerplate into a shared on_shutdown() helper in dashboard_common, simplifying all three call sites. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yonromai
approved these changes
Mar 25, 2026
Helw150
pushed a commit
that referenced
this pull request
Apr 8, 2026
* regression from https://github.com/marin-community/marin/pull/4126/changes --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.