feat(iris): route actor RPC calls through proxy and decode responses by ravwojdyla-agent · Pull Request #4161 · marin-community/marin

ravwojdyla-agent · 2026-03-26T01:00:03Z

Summary

iris rpc actor call --actor-name <full-name> --method-name <method> now automatically sets the x-iris-actor-endpoint header, routing the call through the controller's actor proxy to the correct actor server
ActorResponse serialized_value is auto-unpickled so the CLI prints human-readable JSON instead of opaque base64

Example

uv run iris --config lib/iris/examples/marin-dev.yaml rpc actor call \
  --actor-name "/rav/my-job/zephyr-coord-0" \
  --method-name get_counters

# Output:
{
  "minhash/documents": 7849813,
  "minhash/buckets": 204095138
}

Test plan

Tested live against a running zephyr dedup job on marin-dev
Add unit test for _format_actor_response

🤖 Generated with Claude Code

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ebd049413

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-26T01:04:16Z

+            actor_name = field_values.get("actor_name")
+            if service_name == "actor" and actor_name:


Derive actor proxy header from parsed request body

actor_name is pulled only from field_values (CLI flags), so actor RPCs invoked via --json never set x-iris-actor-endpoint. In that path the proxy receives no routing header and returns 400 Missing x-iris-actor-endpoint, which makes the generic --json request mode unusable for actor methods (for example iris rpc actor call --json '{..."actor_name": ...}'). Read actor_name from the parsed request payload when --json is used.

Useful? React with 👍 / 👎.

rjpower

seems reasonable, but i might suggest that we special case actor calls as their own iris actor call <endpoint> <name> <args> instead. that would give us more flexibility to handle the serialization/pickle stuff and properly handle function arguments.

rjpower · 2026-03-26T01:11:54Z

+    which = response.WhichOneof("result")
+    if which == "serialized_value":
+        value = cloudpickle.loads(response.serialized_value)
+        return json.dumps(value, indent=2, default=str)


is value always json serializable? maybe just wrap in a try/except, fallback to repr

according to claude yes, but will introduce separate cli per request and try/except

rjpower · 2026-03-26T01:13:12Z

        def callback(ctx: click.Context, json_str: str | None, **kwargs):
            controller_url = require_controller_url(ctx)
            field_values = {k: v for k, v in kwargs.items() if v is not None}
            request = build_request(method, json_str, field_values)


does build request do the right thing for actor calls?

It did in my local tests

Dedicated CLI command for actor RPCs instead of bolting onto the generic rpc infrastructure. Handles auth, proxy header injection, cloudpickle deserialization, and JSON kwargs naturally: iris actor call /user/job/coord-0 get_counters iris actor call /user/job/coord-0 get_counters '{"worker_id": "w-3"}' Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

ravwojdyla-agent · 2026-03-26T02:30:55Z

🤖 Validated the CLI against a live fuzzy dedup job on marin-dev. Examples:

# Global counters (accumulated across all stages)
uv run iris --config lib/iris/examples/marin-dev.yaml actor call \
  /rav/iris-run-reference_counter_test-20260326-013741/zephyr-fuzzy-dedup-03c3ddd9-p0-a0/zephyr-fuzzy-dedup-03c3ddd9-p0-coord-0 \
  get_counters
# {"minhash/documents": 4039056, "minhash/buckets": 105015328}

# Per-worker counters (in-flight heartbeat snapshot)
uv run iris --config lib/iris/examples/marin-dev.yaml actor call \
  /rav/.../zephyr-fuzzy-dedup-03c3ddd9-p0-coord-0 \
  get_counters '{"worker_id": "zephyr-fuzzy-dedup-03c3ddd9-p0-workers-0"}'
# {"minhash/documents": 524288, "minhash/buckets": 13631488}

# Get job status
uv run iris --config lib/iris/examples/marin-dev.yaml actor call \
  /rav/.../zephyr-fuzzy-dedup-03c3ddd9-p0-coord-0 \
  get_status

Per-worker values diverge as expected (different shard sizes / processing speeds). Auth token is no longer leaked in logs.

…4161) ## Summary - `iris rpc actor call --actor-name <full-name> --method-name <method>` now automatically sets the `x-iris-actor-endpoint` header, routing the call through the controller's actor proxy to the correct actor server - ActorResponse `serialized_value` is auto-unpickled so the CLI prints human-readable JSON instead of opaque base64 ### Example ```bash uv run iris --config lib/iris/examples/marin-dev.yaml rpc actor call \ --actor-name "/rav/my-job/zephyr-coord-0" \ --method-name get_counters # Output: { "minhash/documents": 7849813, "minhash/buckets": 204095138 } ``` ## Test plan - [x] Tested live against a running zephyr dedup job on marin-dev - [ ] Add unit test for `_format_actor_response` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Rafal Wojdyla <ravwojdyla@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

ravwojdyla-agent added the agent-generated Created by automation/agent label Mar 26, 2026

chatgpt-codex-connector Bot reviewed Mar 26, 2026

View reviewed changes

ravwojdyla requested a review from rjpower March 26, 2026 01:10

rjpower approved these changes Mar 26, 2026

View reviewed changes

ravwojdyla force-pushed the rav-rpc-actor-proxy-cli branch 2 times, most recently from 0a300f7 to 6afb6a0 Compare March 26, 2026 01:34

ravwojdyla force-pushed the rav-rpc-actor-proxy-cli branch from 6afb6a0 to 20704ec Compare March 26, 2026 02:11

ravwojdyla merged commit 2f7e90b into main Mar 26, 2026
41 checks passed

ravwojdyla deleted the rav-rpc-actor-proxy-cli branch March 26, 2026 02:33

ravwojdyla mentioned this pull request Mar 26, 2026

docs: add actor RPC section to debug-zephyr-job skill #4165

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iris): route actor RPC calls through proxy and decode responses#4161

feat(iris): route actor RPC calls through proxy and decode responses#4161
ravwojdyla merged 1 commit intomainfrom
rav-rpc-actor-proxy-cli

ravwojdyla-agent commented Mar 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 26, 2026

Uh oh!

rjpower left a comment

Uh oh!

rjpower Mar 26, 2026

Uh oh!

ravwojdyla Mar 26, 2026 •

edited

Loading

Uh oh!

rjpower Mar 26, 2026

Uh oh!

ravwojdyla Mar 26, 2026

Uh oh!

ravwojdyla-agent commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		actor_name = field_values.get("actor_name")
		if service_name == "actor" and actor_name:

Conversation

ravwojdyla-agent commented Mar 26, 2026

Summary

Example

Test plan

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

rjpower left a comment

Choose a reason for hiding this comment

Uh oh!

rjpower Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

ravwojdyla Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjpower Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

ravwojdyla Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

ravwojdyla-agent commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ravwojdyla Mar 26, 2026 •

edited

Loading