[iris] Fix get_job_info crash on constraint JSON with unknown fields#4169
Closed
claude[bot] wants to merge 1 commit intomainfrom
Closed
[iris] Fix get_job_info crash on constraint JSON with unknown fields#4169claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
Add ignore_unknown_fields=True to json_format.ParseDict in get_job_info() so constraint JSON with fields from newer proto schemas (e.g. mode) does not crash child jobs running older cluster_pb2. Adds regression test. Fixes #4167 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
This will silently use an incorrect constraint, as parent constraints are propagated to their children by default. Should we use a better error message and ask users to update their branch instead? The mode was introduced a week ago so this would be running on at least that stale of a branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ignore_unknown_fields=True to the json_format.ParseDict call in get_job_info() so that IRIS_JOB_CONSTRAINTS JSON containing fields from newer proto schemas (e.g. the mode field added to Constraint) does not crash child jobs running older cluster_pb2. Unknown fields now silently default to proto zero-values. Adds a regression test exercising unknown field tolerance.
Fixes #4167