Fix canary validation artifact replication#4173
Merged
Conversation
ravwojdyla
pushed a commit
that referenced
this pull request
Mar 26, 2026
## Summary - restore canary `tracker_metrics.jsonl` emission by setting `replicate_path=this_output_path()` on the canary W&B tracker - add a regression test that reloads the canary step and asserts metrics replication stays configured - fix the TPU canary post-run validation failure seen in scheduled runs such as 23581948912, where training succeeded but metrics validation failed because the artifact was never written ## Testing - `./infra/pre-commit.py experiments/ferries/canary_ferry.py tests/test_validate_canary_metrics.py` - `uv run --with pytest --with pytest-timeout --with pytest-xdist python -m pytest tests/test_validate_canary_metrics.py` --------- Co-authored-by: yoblin <268258002+yoblin@users.noreply.github.com>
Helw150
pushed a commit
that referenced
this pull request
Apr 8, 2026
## Summary - restore canary `tracker_metrics.jsonl` emission by setting `replicate_path=this_output_path()` on the canary W&B tracker - add a regression test that reloads the canary step and asserts metrics replication stays configured - fix the TPU canary post-run validation failure seen in scheduled runs such as 23581948912, where training succeeded but metrics validation failed because the artifact was never written ## Testing - `./infra/pre-commit.py experiments/ferries/canary_ferry.py tests/test_validate_canary_metrics.py` - `uv run --with pytest --with pytest-timeout --with pytest-xdist python -m pytest tests/test_validate_canary_metrics.py` --------- Co-authored-by: yoblin <268258002+yoblin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracker_metrics.jsonlemission by settingreplicate_path=this_output_path()on the canary W&B trackerTesting
./infra/pre-commit.py experiments/ferries/canary_ferry.py tests/test_validate_canary_metrics.pyuv run --with pytest --with pytest-timeout --with pytest-xdist python -m pytest tests/test_validate_canary_metrics.py