[iris] Remove obsolete CoreWeave CI workflows and configs#4197
Merged
Conversation
Delete ephemeral smoke-cw workflow, dev-restart workflow, multihost canary config/script, and smoke-cw config. These are replaced by the always-on coreweave-ci cluster (iris-coreweave-ci.yaml + coreweave-ci.yaml). Rewrite run_smoke_cw.sh as a thin wrapper over kubectl port-forward + pytest.
Contributor
|
Claude finished @rjpower's task in 53s —— View job ReviewDeletes five obsolete CoreWeave CI files (ephemeral smoke-cw workflow, dev-restart workflow, multihost canary config/script, smoke-cw cluster config) and rewrites
No bugs, correctness issues, or guideline violations found. Clean deletion PR. |
Buildx must be set up before GHCR login, otherwise the GHCR credentials interfere with pulling moby/buildkit from Docker Hub. Also require IRIS_KIND_TESTS=1 env var for Kind-based integration tests since CI runners have Kind installed but cluster creation fails.
Sub-project bundles (e.g. lib/iris) don't include the repo-root uv.lock, so uv sync --frozen fails in task pods. Check for the lockfile at runtime and only pass --frozen when it exists.
The --frozen flag added in #4192 fails on workdirs that don't include uv.lock (e.g. ConfigMap bundles exceeding the 1MB limit). Use a shell conditional to apply --frozen only when the lockfile is present.
yonromai
approved these changes
Mar 27, 2026
Helw150
pushed a commit
that referenced
this pull request
Apr 8, 2026
Delete the ephemeral smoke-cw workflow, dev-restart workflow, multihost canary config and script, and smoke-cw cluster config. All replaced by the always-on coreweave-ci cluster added in #4174. Rewrite run_smoke_cw.sh as a thin kubectl port-forward wrapper over pytest tests/integration/iris/. Deleted: iris-cloud-smoke-cw.yaml, iris-coreweave-dev-restart.yaml, smoke-cw.yaml, coreweave-canary-multihost.yaml, coreweave_multihost.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the ephemeral smoke-cw workflow, dev-restart workflow, multihost
canary config and script, and smoke-cw cluster config. All replaced by
the always-on coreweave-ci cluster added in #4174. Rewrite run_smoke_cw.sh
as a thin kubectl port-forward wrapper over pytest tests/integration/iris/.
Deleted: iris-cloud-smoke-cw.yaml, iris-coreweave-dev-restart.yaml,
smoke-cw.yaml, coreweave-canary-multihost.yaml, coreweave_multihost.py.