[iris] Fix dev_tpu.py to use provider_bundle API#4395
Merged
yonromai merged 1 commit intomarin-community:mainfrom Apr 3, 2026
Merged
[iris] Fix dev_tpu.py to use provider_bundle API#4395yonromai merged 1 commit intomarin-community:mainfrom
yonromai merged 1 commit intomarin-community:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Helw150
pushed a commit
that referenced
this pull request
Apr 8, 2026
## Summary - `scripts/iris/dev_tpu.py` still called `IrisConfig.platform()`, which was removed in #3900 - Replace with `provider_bundle().controller` to match the current `IrisConfig` API Fixes #4394 ## Test plan - [x] `uv run python scripts/iris/dev_tpu.py --help` — CLI loads without import errors - [x] `uv run pytest lib/iris/tests/test_dev_tpu.py` — 4/4 pass - [x] `uv run python scripts/iris/dev_tpu.py --config lib/iris/examples/marin.yaml --tpu-name test-dev-tpu allocate --tpu-type v6e-8` — tunnel established, job submitted to live cluster 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Romain Yon <1596570+yonromai@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/iris/dev_tpu.pystill calledIrisConfig.platform(), which was removed in iris: eliminate Platform abstraction, reorganize into Service + Provider layers #3900provider_bundle().controllerto match the currentIrisConfigAPIFixes #4394
Test plan
uv run python scripts/iris/dev_tpu.py --help— CLI loads without import errorsuv run pytest lib/iris/tests/test_dev_tpu.py— 4/4 passuv run python scripts/iris/dev_tpu.py --config lib/iris/examples/marin.yaml --tpu-name test-dev-tpu allocate --tpu-type v6e-8— tunnel established, job submitted to live cluster🤖 Generated with Claude Code