fix(iris): add SYS_PTRACE to controller pod for profiling#4418
Conversation
The controller Deployment was missing the SYS_PTRACE capability that task pods already have, causing py-spy and memray to fail with "Permission denied (os error 13)" when profiling the controller. Closes #4416 Co-authored-by: Rafal Wojdyla <ravwojdyla@users.noreply.github.com>
| provider.shutdown() | ||
|
|
||
|
|
||
| def test_controller_deployment_has_sys_ptrace(): |
| ], | ||
| "ports": [{"containerPort": port}], | ||
| "env": s3_env_vars, | ||
| "securityContext": {"capabilities": {"add": ["SYS_PTRACE"]}}, |
There was a problem hiding this comment.
are there other capabilities present in the other providers that we should include here?
| ], | ||
| "ports": [{"containerPort": port}], | ||
| "env": s3_env_vars, | ||
| "securityContext": {"capabilities": {"add": ["SYS_PTRACE"]}}, |
There was a problem hiding this comment.
will this work in k8s?
|
@claude address the comments above please |
|
Claude finished @ravwojdyla's task in 2m 35s —— View job Addressing PR review comments
Changes madeRemoved the standalone test ( Answers to review questionsOther capabilities from other providers? — Will this work in k8s? — Yes. Testing
|
The capability is already validated implicitly by test_start_controller_creates_all_resources. Co-authored-by: Rafal Wojdyla <ravwojdyla@users.noreply.github.com>
rjpower
left a comment
rjpower
left a comment
There was a problem hiding this comment.
Your guess is as good as mine! Off the top of my head ptrace is the one I recall adding to the docker runtime.
Adds `SYS_PTRACE` capability to the controller Deployment so py-spy and memray profiling works on the controller pod. Closes #4416 Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Rafal Wojdyla <ravwojdyla@users.noreply.github.com>
2 participants
Adds
SYS_PTRACEcapability to the controller Deployment so py-spy and memray profiling works on the controller pod.Closes #4416
Generated with Claude Code