fix(iris): binary-safe base64 decoding for profile downloads#4422
fix(iris): binary-safe base64 decoding for profile downloads#4422
Conversation
…downloads The download path used atob() → Blob([string]), which UTF-8 encodes the string and corrupts non-ASCII bytes in binary memray .bin traces. Convert base64 to Uint8Array via charCodeAt() to preserve raw bytes. Fixes both useProfileAction.ts and JobDetail.vue. Co-authored-by: Russell Power <rjpower@users.noreply.github.com>
|
Claude finished @rjpower's task in 47s —— View job PR Review: Binary-safe base64 decoding for profile downloads
Verdict: Looks good. The fix is correct — Two minor observations:
Otherwise the change is clean and well-scoped. 👍 |
Fix binary data corruption in memray .bin downloads. The download path used `atob()` → `Blob([string])`, which UTF-8 encodes the string and corrupts non-ASCII bytes. Now uses `Uint8Array` to preserve raw bytes. Followup to #4415.
Fix binary data corruption in memray .bin downloads. The download path used
atob()→Blob([string]), which UTF-8 encodes the string and corrupts non-ASCII bytes. Now usesUint8Arrayto preserve raw bytes.Followup to #4415.
Generated with Claude Code