-
Notifications
You must be signed in to change notification settings - Fork 111
Make default checkpoint retention conservative #4457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,8 +117,9 @@ class SimpleSFTConfig: | |
| steps_per_eval: int = 1000 | ||
| """How often to run validation losses.""" | ||
|
|
||
| steps_per_checkpoint: int = 1000 | ||
| """How often to save checkpoints.""" | ||
| steps_per_checkpoint: int | None = None | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Setting Useful? React with 👍 / 👎. |
||
| """How often to keep a permanent checkpoint. None (default) keeps only the final | ||
| checkpoint; rolling temporary checkpoints are still written for resumption.""" | ||
|
|
||
| steps_per_hf_export: int = 500 | ||
| """How often to save HuggingFace checkpoints.""" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This default now disables periodic Levanter checkpoints, but leaves
steps_per_hf_exportat500, anddefault_dpostill resolves and passes that interval through (experiments/defaults.py), with HF save hooks enabled wheneverhf_save_stepsis set (lib/levanter/src/levanter/main/train_dpo.py). As a result, DPO runs with defaults continue to emit frequent permanent HF checkpoints, which undercuts the new conservative-retention behavior and can cause avoidable artifact bloat.Useful? React with 👍 / 👎.