[iris] Reject child submissions when parent is absent from the DB#4560
Open
claude[bot] wants to merge 2 commits intomainfrom
Open
[iris] Reject child submissions when parent is absent from the DB#4560claude[bot] wants to merge 2 commits intomainfrom
claude[bot] wants to merge 2 commits intomainfrom
Conversation
After a controller restart from a checkpoint that did not capture a parent row, child jobs were silently accepted with `parent_job_id = NULL`, leaving orphaned rows the dashboard `WHERE depth = 1` query never surfaces. Extend launch_job's parent guard to reject absent parents with FAILED_PRECONDITION alongside terminated ones, and drop the silent null fallback in transitions.submit_job. Fixes #4559 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Iris backend in integration_client previously wrapped tests in an IrisContext whose parent job_id did not correspond to a real row in the controller DB; this relied on the silent null-parent fallback that is now removed. Submit a long-running holder job and use its id as the parent context so child submissions have a live parent row. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yonromai
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a controller restart from a checkpoint that did not capture a parent row, child jobs were silently accepted with parent_job_id = NULL, leaving orphaned rows that the dashboard WHERE depth = 1 query never surfaces. Extend launch_job's parent guard to reject absent parents with FAILED_PRECONDITION alongside terminated ones, and drop the silent null fallback in transitions.submit_job. Adds a regression test.
Fixes #4559