[iris] Remove legacy ListJobsRequest fields after JobQuery transition#4574
Open
claude[bot] wants to merge 3 commits intomainfrom
Open
[iris] Remove legacy ListJobsRequest fields after JobQuery transition#4574claude[bot] wants to merge 3 commits intomainfrom
claude[bot] wants to merge 3 commits intomainfrom
Conversation
In JobDetail.vue, flattenedChildJobs and expandableChildJobs used visibleChildJobs (direct children only) as input to flattenJobTree/jobsWithChildren. Since jobsWithChildren detects expandable nodes by finding parent-child pairs in the same list, and the current job was never in visibleChildJobs, no child ever received an expand button. Switch both computeds to use descendantJobs so parent-child pairs are visible and the toggle correctly shows all descendants in all-mode vs interactive expand in direct-mode. Fixes #4552
Drop the deprecated offset/limit/sort_field/sort_direction/name_filter/ state_filter/parent_job_id fields (1-7) from ListJobsRequest in favor of the typed JobQuery envelope added in the parent commit. Reserve the old field numbers in the proto, remove the legacy fallback branches in list_jobs, and migrate all test callers to ListJobsRequest(query=...). Fixes #4573
rjpower
force-pushed
the
claude/bold-leakey
branch
2 times, most recently
from
61b2fd5 to
2ab8fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the deprecated flat fields (offset, limit, sort_field, sort_direction,
name_filter, state_filter, parent_job_id) from ListJobsRequest, keeping only
the typed JobQuery envelope introduced in #4558. Reserves the old proto field
numbers 1-7, removes the legacy fallback branches in list_jobs, and migrates
all test callers to use ListJobsRequest(query=...).
Stacked on #4558 (targets its branch). Retarget to main after that merges.
Fixes #4573