Skip to content

[iris] Remove heartbeat log forwarding dead code#4694

Closed
claude[bot] wants to merge 2 commits intomainfrom
agent/20260413-fix-4692
Closed

[iris] Remove heartbeat log forwarding dead code#4694
claude[bot] wants to merge 2 commits intomainfrom
agent/20260413-fix-4692

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude bot commented Apr 13, 2026

Workers push logs directly via LogPusher; the heartbeat-piggybacked
log_entries path on WorkerTaskStatus was never populated by current
workers. Remove the forwarding block in WorkerProvider, the controller
wiring for it, the proto field (reserved 9), and the three associated
tests.

Fixes #4692

@rjpower
Copy link
Copy Markdown
Collaborator

rjpower commented Apr 13, 2026

@claude rebase to main pls

@claude
Copy link
Copy Markdown
Contributor Author

claude bot commented Apr 13, 2026

Claude finished @rjpower's task in 5m 42s —— View job


Rebase to main

  • Fetch latest main
  • Rebase branch onto origin/main (cherry-picked onto fresh main, resolved 2 conflicts in controller.py and test_heartbeat.py)
  • Run pre-commit checks — all passed
  • Run tests — all 8 remaining heartbeat tests pass
  • Force push updated branch

Done. The branch has been rebased onto current main. The conflicts were in controller.py (log service setup was refactored on main to use RPC-based LogPusher instead of _InProcessLogPusher) and test_heartbeat.py (imports). Resolved by applying the PR's intent (remove WorkerProvider from log pusher wiring + delete the three dead-code tests) on top of main's current code.
· Branch

Workers push logs directly via LogPusher; the heartbeat-piggybacked
log_entries path on WorkerTaskStatus was never populated by current
workers. Remove the forwarding block in WorkerProvider, the controller
wiring for it, the proto field (reserved 9), and the three associated
tests.

Fixes #4692
@claude claude bot force-pushed the agent/20260413-fix-4692 branch from a881033 to b68a64b Compare April 13, 2026 23:08
@rjpower rjpower closed this Apr 16, 2026
@rjpower rjpower deleted the agent/20260413-fix-4692 branch April 16, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-generated Created by automation/agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iris] Remove heartbeat log forwarding now that workers push directly to log service

1 participant