[iris] Remove heartbeat log forwarding dead code#4694
Closed
claude[bot] wants to merge 2 commits intomainfrom
Closed
[iris] Remove heartbeat log forwarding dead code#4694claude[bot] wants to merge 2 commits intomainfrom
claude[bot] wants to merge 2 commits intomainfrom
Conversation
Collaborator
|
@claude rebase to main pls |
Contributor
Author
|
Claude finished @rjpower's task in 5m 42s —— View job Rebase to main
Done. The branch has been rebased onto current main. The conflicts were in |
Workers push logs directly via LogPusher; the heartbeat-piggybacked log_entries path on WorkerTaskStatus was never populated by current workers. Remove the forwarding block in WorkerProvider, the controller wiring for it, the proto field (reserved 9), and the three associated tests. Fixes #4692
a881033 to
b68a64b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workers push logs directly via LogPusher; the heartbeat-piggybacked
log_entries path on WorkerTaskStatus was never populated by current
workers. Remove the forwarding block in WorkerProvider, the controller
wiring for it, the proto field (reserved 9), and the three associated
tests.
Fixes #4692