Merged
Conversation
Contributor
ravwojdyla
commented
Apr 14, 2026
ravwojdyla
commented
- [zephyr] Track per-shard failures and abort after MAX_SHARD_FAILURES #4579 (comment)
Collaborator
|
I'm torn on this, it feels important to surface. You're seeing this because of lots of preemptions I guess? We could rate limit to N per minute with the token bucket rate limiter if you wanted perhaps? |
Contributor
Author
|
@rjpower loads of preemption and large number of shards. |
Contributor
Author
|
@rjpower what part of that log is important?
How about we change it to, count of shards by retry. So log like: Would change into: |
Collaborator
|
Just a notification that we're having failures seems useful. I'm fine if we compress them, since in theory the raw info is on Iris. |
rjpower
approved these changes
Apr 14, 2026
ravwojdyla
force-pushed
the
rav-shards-debug
branch
from
278ca59 to
11d9a0a
Compare
Instead of logging every shard's attempt count, log the histogram of attempts -> shard count. Keeps retry visibility without the per-shard noise on large jobs with many preemptions.
ravwojdyla
force-pushed
the
rav-shards-debug
branch
from
11d9a0a to
5363f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.