Skip to content

Ignore worktrees.#4797

Merged
rjpower merged 1 commit intomainfrom
rjpower/20260415-ignore-worktress
Apr 15, 2026
Merged

Ignore worktrees.#4797
rjpower merged 1 commit intomainfrom
rjpower/20260415-ignore-worktress

Conversation

@rjpower
Copy link
Copy Markdown
Collaborator

@rjpower rjpower commented Apr 15, 2026

No description provided.

@rjpower rjpower merged commit d96d45a into main Apr 15, 2026
15 of 16 checks passed
@rjpower rjpower deleted the rjpower/20260415-ignore-worktress branch April 15, 2026 22:14
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 15, 2026

Claude finished @rjpower's task in 58s —— View job


PR Review: Ignore worktrees

  • Read PR diff
  • Inspect .gitignore change
  • Post review

This PR is already merged and is a trivial 2-line change adding .worktrees to .gitignore (commit d96d45a). The diff is just:

+
+.worktrees

Findings

Looks good — Sensible addition consistent with the surrounding pattern. The other agent/tool directories (.forge, .claude, .codex, .entire) are all bare entries in the same block, so .worktrees slots in cleanly.

Minor (non-blocking) considerations

  1. Pattern scope.worktrees (no leading / or trailing /) matches any file or directory named .worktrees anywhere in the repo, not just the top level. If the intent is specifically the top-level git worktrees directory created by git worktree add .worktrees/..., /.worktrees/ would be more precise. That said, this matches the convention of the other agent-tool entries directly above it, so consistency wins.

  2. Convention note — The git worktree convention some teams use is .git/worktrees/ (managed by git itself). This entry suggests a separate .worktrees/ directory created by user/agent tooling (e.g., EnterWorktree-style isolation). Worth confirming the directory name matches what the worktree-creating tooling actually produces — e.g., the Agent tool's isolation: "worktree" mode places worktrees somewhere; if that path differs, this won't catch them.

No action needed — PR is merged and the change is benign.
| Branch: claude/pr-4797-20260415-2214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant