[iris] Merge test_budget_api.py into test_budget.py; remove slop#4870
Merged
[iris] Merge test_budget_api.py into test_budget.py; remove slop#4870
Conversation
Collapse repetitive resource_value / compute_effective_band cases into parametrized tests, drop the tautological PRIORITY_BAND ordering check and the weak-assertion interleave_by_user duplicates, and fold the admin API tests from test_budget_api.py into the same file behind a shared service fixture. Fixes #4869
yonromai
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse repetitive resource_value and compute_effective_band cases into parametrized tests, drop the tautological PRIORITY_BAND ordering assertion and the weak-assertion interleave_by_user duplicates, and fold the admin API tests from test_budget_api.py into the same file behind a shared service fixture. Net: 644 -> 307 lines, 32 tests still passing.
Fixes #4869