Skip to content

Fix Arrow Flight host resolution and skip PlantCAD dry-run #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjpower merged 1 commit into from
Apr 23, 2026
+4 −2
Merged

Fix Arrow Flight host resolution and skip PlantCAD dry-run #5064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions experiments/plantcad/exp1729_plantcad_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@

logger = logging.getLogger(__name__)

# nodryrun


# -----------------------------------------------------------------------------
# Configuration
Expand Down
4 changes: 2 additions & 2 deletions lib/marin/src/marin/rl/weight_transfer/arrow_flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ def _resolve_advertise_host() -> str:
pass

hostname = socket.gethostname()
# gRPC's c-ares DNS resolver can't handle .local (mDNS) hostnames
if hostname.endswith(".local"):
# gRPC's c-ares DNS resolver can't handle .local (mDNS) or .localdomain hostnames
Copy link
Copy Markdown
Collaborator

@rjpower rjpower Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could open a socket on the 0.0.0.0 and see what IP it binds but this seems fine too.

if hostname.endswith(".local") or hostname.endswith(".localdomain"):
return "localhost"
Comment thread
rjpower marked this conversation as resolved.
return hostname

Expand Down
Loading