Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6db4942d87
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| def favicon_route() -> Route: | ||
| """Route for serving favicon.ico from the Vue dashboard dist root.""" | ||
| return Route("/favicon.ico", _favicon) |
There was a problem hiding this comment.
The new Route("/favicon.ico", _favicon) endpoint is unannotated, and _RouteAuthMiddleware default-denies any matched Route without @public/@requires_auth when dashboard auth is enabled. In clusters with auth configured, requests to /favicon.ico will therefore return 401 (not the icon), so the feature does not work in the primary authenticated deployment path; this route should be explicitly marked public (or otherwise skipped by policy) like other unauthenticated UI assets.
Useful? React with 👍 / 👎.
wmoss
force-pushed
the
iris-favicon
branch
2 times, most recently
from
daba59c to
e46c82b
Compare
Mostly just trying to make it easier for me to find the tab in chrome
rjpower
left a comment
rjpower
left a comment
There was a problem hiding this comment.
Haha critically important indeed...
2 participants
Felt like Iris needed more personality 😄
Mostly just trying to make it easier for me to find the tab in chrome