[iris] Add --preemptible flag to job run#5083
Merged
Conversation
Lets callers force scheduling on (non-)preemptible workers instead of relying on the small-CPU-only executor heuristic. The flag threads through run_iris_job() and appends a preemptible_constraint before infer_preemptible_constraint runs; the heuristic already short-circuits when any preemptible constraint is present, so the explicit flag wins. Also extracts constraint assembly into build_job_constraints() to keep the new behavior pure and directly unit-testable without mocking the controller. Fixes #4540 Co-authored-by: Russell Power <rjpower@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbbfe56821
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --preemptible/--no-preemptible to iris job run, letting callers force
scheduling on (non-)preemptible workers instead of relying on the small-CPU
executor heuristic. Constraint assembly is factored into build_job_constraints
for direct unit testing without mocking the controller.
Fixes #4540