datakit-smoke: verify source staging in us-central1#5106
Merged
ravwojdyla merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
ravwojdyla-agent
changed the title
Runs the ~72 unique DatakitSource.staged_path prefixes past gs://marin-us-central1 each day in parallel with the ferry, so a staged dump that is deleted or otherwise disappears surfaces before the next ferry run 404s on download. Covers every source with a non-None staged_path, not just the pinned subset — unpinned entries still point at real bytes the registry claims exist. notify-slack now watches both lanes so either failure pages Slack; claude-triage stays scoped to the ferry (the sources check explains itself from its own error output). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Tighten the lane from "prefix has at least one object" to "the executor step that produced it reports SUCCESS". Reuses StatusFile so both the plain-text and legacy JSON-lines formats are handled (the former is a single token, the latter is an event log where the latest status wins). Surfaces two existing issues in the registry on first run: - raw/common_corpus_english-b78a5c1: no .executor_status file at all - raw/finetranslations_d17a789b: status=RUNNING (never terminated) Both will need to be cleaned up — or the source entries dropped from the registry — for this lane to go green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ravwojdyla
force-pushed
the
rav-datakit-sources-staged-check
branch
from
664ed9c to
3e2ab77
Compare
Helw150
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datakit-sources-stagedinmarin-datakit-smoke.yaml, runs alongside the ferry on the same schedulescripts/datakit/validate_source_staging.py—ThreadPoolExecutoroverStatusFile(<full_path>).statusfor the 70 uniqueDatakitSource.staged_pathprefixes undergs://marin-us-central1, exits non-zero with a per-path<status>: <url>report when any is notSUCCESS1staged_path, not just the pinned subsetmarin.execution.executor_step_status.StatusFileso both the plain-text and legacy JSON-lines.executor_statusformats are handlednotify-slacknow fans in from both lanes vianeeds: [datakit-smoke, datakit-sources-staged]— either failure pages Slack on scheduled runsSUCCESS— the two previous offenders (common_corpus_english-b78a5c1,finetranslations_d17a789b) were dropped from the registry on main, so this lane goes green on day oneFootnotes
fs.lsnon-empty was the earlier bar, which both of the now-dropped paths passed; tightening toSUCCESSis the point — a half-written or abandoned dump must not quietly flow into a ferry. ↩