[zephyr] skip status log when no counters recorded#5176
Conversation
Map-only stages don't run their output through StatisticsGenerator, so the periodic status logger spammed `items=0 (0.0/s), bytes_processed=0.0MiB` for the entire shard runtime. Skip the log line until at least one of the item/byte counters has been recorded — once data starts flowing, zeroes from one side are still informative. Fixes #5175. Co-authored-by: Will Moss <wmoss@users.noreply.github.com>
|
Claude finished @wmoss's task in 2m 10s —— View job Code reviewNo issues found. Checked for bugs and CLAUDE.md/AGENTS.md compliance. The change is minimal and well-scoped:
|
ravwojdyla
left a comment
There was a problem hiding this comment.
We need to update the coordinator as well?
Fixes #5175.
Map-only stages don't run their output through
StatisticsGenerator, so the periodic status logger insubprocess_worker._periodic_status_loggerkept emittingitems=0 (0.0/s), bytes_processed=0.0MiBfor the entire shard runtime — noisy and misleading. Now we skip the log line entirely until at least one of the item/byte counters has been recorded.Generated with Claude Code