Move task status updates onto the RPC loop.#5768
Conversation
|
Claude finished @rjpower's task in 5m 50s —— View job Code reviewNo issues found. Checked for bugs and CLAUDE.md / AGENTS.md compliance. What was reviewed
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ffb73883d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| # --- Task Status Text Push --- | ||
|
|
||
| @on_loop |
There was a problem hiding this comment.
Keep SetTaskStatusText off the ASGI event loop
Decorating set_task_status_text with @on_loop moves this hot push-path onto the single-threaded ASGI event loop, so bursts of status updates from many running tasks are handled serially and can queue unrelated RPCs behind them. In practice this can degrade controller responsiveness (e.g., job control and worker RPC latency) under load, because AsyncServiceAdapter runs @on_loop handlers inline instead of asyncio.to_thread.
Useful? React with 👍 / 👎.
No description provided.