[marin] datakit discovery: skip artifact.json/provenance.json sidecars#5865
Closed
claude[bot] wants to merge 1 commit into
Closed
[marin] datakit discovery: skip artifact.json/provenance.json sidecars#5865claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
PR #5732 renamed the executor artifact sidecar from .artifact to artifact.json, which now slips past normalize._discover_files' extension+dotfile filter. When the upstream step's fn returns None, Artifact.save writes literal 'null', which load_jsonl decodes to None and has_text crashes on. decon._discover_eval_files has the same gap for provenance.json. Filter both by basename via a SIDECAR_FILENAMES constant. Fixes #5864
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #5732 renamed the executor artifact sidecar from .artifact to artifact.json, normalize._discover_files (extension+dotfile filter only) now picks it up as input; a step whose fn returns None saves literal null, which load_jsonl decodes to None and has_text crashes on. decon._discover_eval_files has the same gap for provenance.json. Filter both by basename via a shared SIDECAR_FILENAMES constant.
Fixes #5864