Closed
Conversation
f08556f to
dfad663
Compare
dfad663 to
e0806c9
Compare
Contributor
I like the idea of it being a subproject because it makes it easier to keep this code and Marin in sync. Lessens concerns about updates to Marin not being picked up here. The other way to handle this would be to make Marin depend on this repo, but my assumption is this wouldn't happen in the short term. If that assumption is wrong, I don't have as strong a preference. |
Member
|
I think I'd be happy to depend on this assuming we don't break existing cached steps (or make a careful decision to do so) |
Member
|
Closed in favor of #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the initial configuration of a project to potentially contain the Marin Executor code. Some immediate questions I have are:
experimentsin Tutorial fails with "experiments" not on PYTHONPATH marin#1507 (comment)I have copied most of the configurations from Marin, with no significant modifications other than many deletions. Here are diffs from the original files for those that have changed in some noteworthy way:
pyproject.toml
.pre-commit-config.yaml
.github/workflows/unit-tests.yaml
TODO: Is there a better way to get cross-repo file diffs with no shared lineage?