Fix nullable reference conversion elision for user-defined conversions #1102
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
op_Implicitwhen targeting nullable reference unions.Nullable<T>(reference underlying) too broadly, which suppressed emitted conversion calls.implicit operatorinOptionExtensions<T>and runtime failures when the conversion was expected to run.Description
BlockBinder.ApplyConversionso the early-return forNullableTypeSymbolonly occurs whenconversion.IsReferenceand the expression type exactly equals the nullable underlying type usingSymbolEqualityComparer.Default.Equals.op_Implicit) are considered and emitted for nullable reference targets instead of being elided.src/Raven.CodeAnalysis/Binder/BlockBinder.csby refining theif (targetType is NullableTypeSymbol ...)condition.Testing
NodeGenerator,BoundNodeGenerator,DiagnosticsGenerator) before building as required by repository guidelines.dotnet build --property WarningLevel=0, which completed successfully.dotnet test test/Raven.CodeAnalysis.Tests /property:WarningLevel=0 -v minimal, which exercised the test suite but encountered many preexisting and unrelated failures; tests did not all pass.Codex Task