fix(renovate): skip devcontainer base digest pinning - #828
Merged
Conversation
Keep the repo-owned devcontainer base on its intentionally floating tag while preserving digest pinning for third-party images.
robarnold
marked this pull request as ready for review
August 4, 2026 04:45
Contributor
|
What if we just update it weekly (Mondays)? |
Contributor
Author
|
I worry it is another two points of failure: automation deps and fedora's retention policy & behavior not change from under us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The inherited
config:best-practicespreset enablesdocker:pinDigests. Renovate therefore treats thelatestdefault used by.devcontainer/Containerfileas an unpinned Docker tag and creates PRs such as #813.This image is built, validated, and published by this repository. Keeping its developer fallback tag floating avoids a circular self-update PR after each publication, while regular CI continues to override it with the commit-specific locally built candidate.
Validation
jq empty renovate.jsongit diff --checkrenovate-config-validator --no-global renovate.jsonghcr.io/marinatedconcrete/devcontainer-basewithpinDigests: false