fix(DisjointSetBenchmark): rename ElementCount param to ItemCount so its dashboard card renders - #284
Merged
Merged
Conversation
…the dashboard card renders The benchmark dashboard (web/dev/bench/index.html and detail.html) parses BDN benchmark names with a regex that requires the literal `ItemCount:` in the parameter suffix. DisjointSetBenchmark emitted `(ElementCount: N)`, so `parseName` returned null for every arm and the DisjointSet card showed no data. Rename the `[Params]` property from `ElementCount` to `ItemCount` (matching every other core benchmark) so the emitted name matches the regex. No benchmark logic changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Coverage
Files below 100% line coverage
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the benchmark dashboard’s name parsing for DisjointSetBenchmark by renaming its BenchmarkDotNet [Params] member from ElementCount to ItemCount, matching the dashboard regex used to extract the parameter suffix.
Changes:
- Renamed the benchmark parameter field to
ItemCountso emitted BDN names match(...ItemCount: N). - Updated all internal uses in setup and builder methods to reference
ItemCount.
Benchmarks12 regressions Highlights
Collections (376)
Hashers (100)
Same-runner A/B (sharded 6-way): main ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The benchmark dashboard JS in
web/dev/bench/index.htmlandweb/dev/bench/detail.htmlparses BenchmarkDotNet names with:which requires the literal
ItemCount:in the parameter suffix.DisjointSetBenchmarkdeclared its param as[Params(1000, 100_000)] public int ElementCount;, so it emitted(ElementCount: N).parseNamereturnednullfor every DisjointSet arm and the DisjointSet dashboard card rendered no data. Every other core benchmark (CeleritySet, Deque, LruCache, IndexedPriorityQueue, …) usesItemCount.Fix
Rename the
[Params]property fromElementCounttoItemCountthroughoutDisjointSetBenchmark.cs(setup + both builders). The emitted BDN name now matches the dashboard regex, so the card will render after the next gh-pages benchmark publish onmain.No benchmark logic changes — just the parameter name. Benchmarks project builds clean in Release (0 warnings).
🤖 Generated with Claude Code