Skip to content

docs(StringFnV1AHasher): replace tutorial-style loop comment #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marius-bughiu merged 2 commits into from
Jul 23, 2026
Merged

docs(StringFnV1AHasher): replace tutorial-style loop comment #295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09b5242
docs(StringFnV1AHasher): replace tutorial-style loop comment
marius-bughiu Jul 23, 2026
0df94d9
more accurate description of collision risk
marius-bughiu Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Celerity.Hashing/StringFnV1AHasher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ public int Hash(string key)
uint hash = offsetBasis;
foreach (char c in key)
{
// Convert char to its lower byte; you may also want to consider
// encoding specifics if you deal with non-ASCII characters.
// Fold only the low byte of each UTF-16 code unit. Characters that share a
// low byte but differ in their high byte (i.e., U+0100 and above) collide here; use
// StringFnV1AFullHasher when that distinction matters.
Comment thread
Copilot marked this conversation as resolved.
hash ^= (byte)(c & 0xFF);
hash *= fnvPrime;
}
Expand Down
Loading