fix(web): close SSE on result event to prevent 502 on send - #14
Merged
Conversation
When the stream-json result event arrives, close the SSE connection and transition to completed/failed immediately. Previously we waited for the SSE done event, but the container is already shutting down by then — user input sent in the gap returned 502.
|
helPRs session created for this PR. Skill: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resultevent arrivesdoneeventThe
resultevent means Claude is done. The container starts shutting down immediately, but the SSEdoneevent arrives later. In that gap, the input bar was still visible and users got 502s.Test plan
npx tsc --noEmitpassesnpx vitest run— 53 tests pass