fix(container): emit SSE done event on stream end - #17
Merged
Conversation
The SSE stream endpoint now yields an `event: done` frame after docker logs end, and marks the session COMPLETED in the DB via mark_completed(). Previously the frontend relied on the SSE connection closing (which no longer happens between turns with the per-turn entrypoint loop).
|
helPRs session created for this PR. Skill: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event: doneframe when the container exits (docker logs end)mark_completed()to transition the session to COMPLETED in the DBChanges
apps/api/src/helprs/modules/container/router.py_event_stream()yieldsevent: done+ callsmark_completed()after stream endsapps/api/tests/modules/container/test_router.pydoneevent emitted + session marked COMPLETED. Also fixedFakeDockerClientForRouter(newline-terminated logs,write_to_container), registeredset_session_factoryin fixtureTest plan
doneevent and shows "Session completed"